Messages in this thread | | | Subject | Re: [PATCH v3 1/7] regulator: qcom-labibb: Implement voltage selector ops | From | AngeloGioacchino Del Regno <> | Date | Mon, 18 Jan 2021 18:54:26 +0100 |
| |
Il 18/01/21 13:04, Mark Brown ha scritto: > On Sun, Jan 17, 2021 at 11:08:24PM +0100, AngeloGioacchino Del Regno wrote: >> Implement {get,set}_voltage_sel, list_voltage, map_voltage with >> the useful regulator regmap helpers in order to be able to manage >> the voltage of LAB (positive) and IBB (negative) regulators. > > Please do not submit new versions of already applied patches, please > submit incremental updates to the existing code. Modifying existing > commits creates problems for other users building on top of those > commits so it's best practice to only change pubished git commits if > absolutely essential. >
Sorry for that. Should I send a v4 to fix that?
- Angelo
| |