lkml.org 
[lkml]   [2021]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 1/5] ALSA: hda/tegra: Use clk_bulk helpers
From
Date
15.01.2021 18:22, Thierry Reding пишет:
...
>> static int hda_tegra_first_init(struct azx *chip, struct platform_device *pdev)
>> {
>> struct hda_tegra *hda = container_of(chip, struct hda_tegra, chip);
>> @@ -495,7 +441,11 @@ static int hda_tegra_probe(struct platform_device *pdev)
>> return err;
>> }
>>
>> - err = hda_tegra_init_clk(hda);
>> + hda->clocks[hda->nclocks++].id = "hda";
>> + hda->clocks[hda->nclocks++].id = "hda2hdmi";
>> + hda->clocks[hda->nclocks++].id = "hda2codec_2x";
>
> Originally the code did this in this order: "hda", "hda2codec_2x" and
> "hda2hdmi". I don't expect the exact order to be very relevant, but was
> there any particular reason to change it?

The reason was "to make code look nicer". This was a conscious decision
since indeed the clocks order shouldn't matter for this driver.

\
 
 \ /
  Last update: 2021-01-18 00:34    [W:0.070 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site