lkml.org 
[lkml]   [2021]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] arcnet: fix macro name when DEBUG is defined
From
Date
On Sun, 2021-01-17 at 10:15 -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> When DEBUG is defined this error occurs
>
> drivers/net/arcnet/com20020_cs.c:70:15: error: ‘com20020_REG_W_ADDR_HI’
>   undeclared (first use in this function);
>   did you mean ‘COM20020_REG_W_ADDR_HI’?
>        ioaddr, com20020_REG_W_ADDR_HI);
>                ^~~~~~~~~~~~~~~~~~~~~~
>
> From reviewing the context, the suggestion is what is meant.
>
> Fixes: 0fec65130b9f ("arcnet: com20020: Use arcnet_<I/O> routines")

Nice find thanks, especially seeing as how this hasn't been tested or
compiled in 5+ years...

commit 0fec65130b9f11a73d74f47025491f97f82ba070
Author: Joe Perches <joe@perches.com>
Date: Tue May 5 10:06:06 2015 -0700

Acked-by: Joe Perches <joe@perches.com>

> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/net/arcnet/com20020_cs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/arcnet/com20020_cs.c b/drivers/net/arcnet/com20020_cs.c
> index cf607ffcf358..81223f6bebcc 100644
> --- a/drivers/net/arcnet/com20020_cs.c
> +++ b/drivers/net/arcnet/com20020_cs.c
> @@ -67,7 +67,7 @@ static void regdump(struct net_device *dev)
>   /* set up the address register */
>   count = 0;
>   arcnet_outb((count >> 8) | RDDATAflag | AUTOINCflag,
> - ioaddr, com20020_REG_W_ADDR_HI);
> + ioaddr, COM20020_REG_W_ADDR_HI);
>   arcnet_outb(count & 0xff, ioaddr, COM20020_REG_W_ADDR_LO);
>  
>
>   for (count = 0; count < 256 + 32; count++) {


\
 
 \ /
  Last update: 2021-01-17 19:29    [W:0.058 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site