Messages in this thread | | | Date | Fri, 15 Jan 2021 17:26:10 +0100 | From | Thierry Reding <> | Subject | Re: [PATCH] drm/tegra: fix reference leak when pm_runtime_get_sync fails |
| |
On Tue, Dec 01, 2020 at 08:56:31PM +0800, Qinglang Miao wrote: > The PM reference count is not expected to be incremented on > return in these tegra functions. > > However, pm_runtime_get_sync will increment the PM reference > count even failed. Forgetting to putting operation will result > in a reference leak here. > > Replace it with pm_runtime_resume_and_get to keep usage > counter balanced. > > Fixes: fd67e9c6ed5a ("drm/tegra: Do not implement runtime PM") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com> > --- > drivers/gpu/drm/tegra/dc.c | 2 +- > drivers/gpu/drm/tegra/dsi.c | 2 +- > drivers/gpu/drm/tegra/hdmi.c | 2 +- > drivers/gpu/drm/tegra/hub.c | 2 +- > drivers/gpu/drm/tegra/sor.c | 2 +- > drivers/gpu/drm/tegra/vic.c | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-)
Applied, thanks.
Thierry [unhandled content-type:application/pgp-signature] | |