Messages in this thread | | | From | Doug Anderson <> | Date | Fri, 15 Jan 2021 17:04:49 -0800 | Subject | Re: [PATCH v5 4/4] pinctrl: qcom: Don't clear pending interrupts when enabling |
| |
Hi,
On Fri, Jan 8, 2021 at 4:36 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > Hi Doug, > > this is an impressive patch. > > We definitely need to touch base with Bjorn on this, preferably also > Sboyd. > > On Fri, Jan 8, 2021 at 6:35 PM Douglas Anderson <dianders@chromium.org> wrote: > > > Fixes: 4b7618fdc7e6 ("pinctrl: qcom: Add irq_enable callback for msm gpio") > > Fixes: 71266d9d3936 ("pinctrl: qcom: Move clearing pending IRQ to .irq_request_resources callback") > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > Some mechanics:
I just realized that I addressed everyone's comments but yours. Doh!
> 1. Does this need to go into stable? Or is current (non-urgent) fine? Or fixes > for v5.10? I.e. required destination.
It probably ought to go into stable, but I'll leave it up to you which version of Linux it lands in. I don't personally know if anyone is criticall waiting on this to land upstream. For Chrome OS we're not desperate for it because we've already landed a temporary revert of Maulik's previous patch and the extra clearing of the masked interrupts isn't causing any really visible problems for us.
> 2. If it does, should patches 1-3 also go into stable? And are they > prerequisites?
Yeah, the last patch requires the previous ones, so they would all need to go into stable together.
-Doug
| |