Messages in this thread | | | Subject | Re: [PATCH v6 16/16] platform/surface: aggregator: fix a kernel-doc markup | From | Maximilian Luz <> | Date | Thu, 14 Jan 2021 15:53:07 +0100 |
| |
On 1/14/21 9:04 AM, Mauro Carvalho Chehab wrote: > A function has a different name between their prototype > and its kernel-doc markup: > > ../drivers/platform/surface/aggregator/ssh_request_layer.c:1065: warning: expecting prototype for ssh_rtl_tx_start(). Prototype was for ssh_rtl_start() instead > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > --- > drivers/platform/surface/aggregator/ssh_request_layer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/surface/aggregator/ssh_request_layer.c b/drivers/platform/surface/aggregator/ssh_request_layer.c > index bb1c862411a2..25db4d638cfa 100644 > --- a/drivers/platform/surface/aggregator/ssh_request_layer.c > +++ b/drivers/platform/surface/aggregator/ssh_request_layer.c > @@ -1056,7 +1056,7 @@ void ssh_rtl_destroy(struct ssh_rtl *rtl) > } > > /** > - * ssh_rtl_tx_start() - Start request transmitter and receiver. > + * ssh_rtl_start() - Start request transmitter and receiver. > * @rtl: The request transport layer. > * > * Return: Returns zero on success, a negative error code on failure. >
Thanks! Looks good to me.
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
There seems to be another issue similar to this, specifically the non-existing ssh_rtl_tx_start() and ssh_rtl_tx_start() are referenced. Both should point to to ssh_rtl_start() instead. I'll start working on a patch to fix that right away.
Regards, Max
| |