Messages in this thread | | | Date | Fri, 15 Jan 2021 14:44:25 +1000 | From | Peter Hutterer <> | Subject | Re: [PATCH] HID: hid-input: avoid splitting keyboard, system and consumer controls |
| |
On Wed, Jan 13, 2021 at 10:24:13PM -0800, Dmitry Torokhov wrote: > A typical USB keyboard usually splits its keys into several reports: > > - one for the basic alphanumeric keys, modifier keys, F<n> keys, six pack > keys and keypad. This report's application is normally listed as > GenericDesktop.Keyboard > - a GenericDesktop.SystemControl report for the system control keys, such > as power and sleep > - Consumer.ConsumerControl report for multimedia (forward, rewind, > play/pause, mute, etc) and other extended keys. > - additional output, vendor specific, and feature reports > > Splitting each report into a separate input device is wasteful and even > hurts userspace as it makes it harder to determine the true capabilities > (set of available keys) of a keyboard, so let's adjust application > matching to merge system control and consumer control reports with > keyboard report, if one has already been processed. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Peter Hutterer <peter.hutterer@who-t.net>
I think, let's see if there's any fallout from that :)
Cheers, Peter
| |