lkml.org 
[lkml]   [2021]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 2/2] dt-bindings: pinctrl: Add bindings for Awinic AW9523/AW9523B
On Wed, Jan 13, 2021 at 6:30 AM AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org> wrote:
>
> Il 13/01/21 03:41, Rob Herring ha scritto:
> > On Mon, Jan 11, 2021 at 07:29:28PM +0100, AngeloGioacchino Del Regno wrote:
> >> Add bindings for the Awinic AW9523/AW9523B I2C GPIO Expander driver.
> >>
> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> >> ---
> >> .../pinctrl/awinic,aw9523-pinctrl.yaml | 112 ++++++++++++++++++
> >> 1 file changed, 112 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/pinctrl/awinic,aw9523-pinctrl.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/pinctrl/awinic,aw9523-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/awinic,aw9523-pinctrl.yaml
> >> new file mode 100644
> >> index 000000000000..a705c05bb5a2
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/pinctrl/awinic,aw9523-pinctrl.yaml
> >> @@ -0,0 +1,112 @@
> >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/pinctrl/awinic,aw9523-pinctrl.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: Awinic AW9523/AW9523B I2C GPIO Expander
> >> +
> >> +maintainers:
> >> + - AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> >> +
> >> +description: |
> >> + The Awinic AW9523/AW9523B I2C GPIO Expander featuring 16 multi-function
> >> + I/O, 256 steps PWM mode and interrupt support.
> >> +
> >> +properties:
> >> + compatible:
> >> + const: awinic,aw9523-pinctrl
> >> +
> >> + reg:
> >> + maxItems: 1
> >> +
> >> + '#gpio-cells':
> >> + description: |
> >> + Specifying the pin number and flags, as defined in
> >> + include/dt-bindings/gpio/gpio.h
> >> + const: 2
> >> +
> >> + gpio-controller: true
> >> +
> >> + gpio-ranges:
> >> + maxItems: 1
> >> +
> >> + interrupt-controller: true
> >> +
> >> + interrupts:
> >> + maxItems: 1
> >> + description: Specifies the INTN pin IRQ.
> >> +
> >> + '#interrupt-cells':
> >> + description:
> >> + Specifies the PIN numbers and Flags, as defined in defined in
> >> + include/dt-bindings/interrupt-controller/irq.h
> >> + const: 2
> >> +
> >> +#PIN CONFIGURATION NODES
> >> +patternProperties:
> >> + '^.*$':
> >> + if:
> >> + type: object
> >> + $ref: "/schemas/pinctrl/pincfg-node.yaml"
> >> + then:
> >
> > I wish people would stop copying this if/then hack...
> >
> > For new bindings, just name your nodes something sensible you can match
> > on like '-pins$'.
> >
> I always check the newest available yaml that I can find in the same
> folder before writing mine... in this case, it was sm8250-pinctrl.yaml
> and I thought that this was the accepted way, since.. that's.. the
> newest one.

Normally, that's a good strategy. Unfortunately, this one went in
without my review. There was supposed to be a follow-up to fix some of
the issues, but seems that never happened.

Rob

\
 
 \ /
  Last update: 2021-01-14 23:46    [W:0.085 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site