Messages in this thread | | | From | Brendan Higgins <> | Date | Thu, 14 Jan 2021 14:19:57 -0800 | Subject | Re: [PATCH v2 3/4] kunit: tool: use `with open()` in unit test |
| |
On Wed, Dec 2, 2020 at 11:09 AM Daniel Latypov <dlatypov@google.com> wrote: > > The use of manual open() and .close() calls seems to be an attempt to > keep the contents in scope. > But Python doesn't restrict variables like that, so we can introduce new > variables inside of a `with` and use them outside. > > Do so to make the code more Pythonic. > > Signed-off-by: Daniel Latypov <dlatypov@google.com>
Tested-by: Brendan Higgins <brendanhiggins@google.com> Acked-by: Brendan Higgins <brendanhiggins@google.com>
| |