lkml.org 
[lkml]   [2021]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH V4] arch: kernel: cpu: x86/resctrl: Takes a letter away and append a colon to match below struct member
    From
    Date
    Hi Bhaskar,

    The prefix in the subject line should be "x86/resctrl:" only. The
    subject line could be (also taking liberty to shorten it here):
    x86/resctrl: Fix typo and append a colon to match struct member

    I would like to repeat my suggestion made in response to your previous
    version, especially if you are planning cleanup in many areas of the
    kernel: Use "git log" to take a look at the custom of patches in the
    area you are contributing to. While the kernel may appear to be a single
    code base there can be different customs in the various subsystems.

    On 1/12/2021 6:03 PM, Bhaskar Chowdhury wrote:
    > s/kernlfs/kernfs/
    > s/@mon_data_kn/@mon_data_kn:/
    >
    > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
    > ---
    > Changes from V3: Fix the subject line typo stuc to struct and mention cpu architecture
    > arch/x86/kernel/cpu/resctrl/internal.h | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
    > index ee71c47844cb..ef9e2c0809b8 100644
    > --- a/arch/x86/kernel/cpu/resctrl/internal.h
    > +++ b/arch/x86/kernel/cpu/resctrl/internal.h
    > @@ -142,7 +142,7 @@ enum rdtgrp_mode {
    >
    > /**
    > * struct mongroup - store mon group's data in resctrl fs.
    > - * @mon_data_kn kernlfs node for the mon_data directory
    > + * @mon_data_kn: kernfs node for the mon_data directory
    > * @parent: parent rdtgrp
    > * @crdtgrp_list: child rdtgroup node list
    > * @rmid: rmid for this rdtgroup
    > --
    > 2.20.1
    >

    Reinette

    \
     
     \ /
      Last update: 2021-01-13 18:14    [W:3.056 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site