lkml.org 
[lkml]   [2021]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 1/2] dt-bindings: input: cros-ec-keyb: Add a new property
From
Date
Quoting Philip Chen (2021-01-12 15:29:11)
> On Mon, Jan 11, 2021 at 6:10 PM Stephen Boyd <swboyd@chromium.org> wrote:
> > Quoting Philip Chen (2021-01-07 15:42:08)
> > > ---
> > > diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> > > index 8e50c14a9d778..7acdb33781d30 100644
> > > --- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> > > +++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> > > @@ -31,6 +31,16 @@ properties:
> > > if the EC does not have its own logic or hardware for this.
> > > type: boolean
> > >
> > > + function-row-physmap:
> >
> > Is there any minimum/maximum number of elements possible?
> The maximum is 15.
> There is no definition for the minimum - we can probably say the minimum is 1.

Ok cool. Please add min/max of 1 to 15 to the binding.

> >
> > > + $ref: '/schemas/types.yaml#/definitions/uint32-array'
> > > + description: |
> > > + An ordered u32 array describing the rows/columns (in the scan matrix)
> > > + of top row keys from physical left (KEY_F1) to right. Each entry
> > > + encodes the row/column as:
> > > + (((row) & 0xFF) << 24) | (((column) & 0xFF) << 16)
> > > + where the lower 16 bits are reserved. This property is specified only
> > > + when the keyboard has a custom design for the top row keys.
> > > +

\
 
 \ /
  Last update: 2021-01-13 07:55    [W:0.097 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site