lkml.org 
[lkml]   [2021]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 2/2] arm64: dts: mt8183: Add krane-sku0 board.
On Wed, Jan 13, 2021 at 11:20 AM Rob Herring <robh@kernel.org> wrote:
>
> On Thu, Jan 07, 2021 at 01:22:06PM +0800, Hsin-Yi Wang wrote:
> > Similar to krane-sku176 but using a different panel source.
> >
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> > ---
> > Change:
> > v2: move compatible to board dts
> > ---
> > .../devicetree/bindings/arm/mediatek.yaml | 1 +
> > arch/arm64/boot/dts/mediatek/Makefile | 1 +
> > .../dts/mediatek/mt8183-kukui-krane-sku0.dts | 23 +++++++++++++++++++
> > 3 files changed, 25 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dts
> >
> > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > index 53f0d4e3ea982..3276f7a2ce672 100644
> > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > @@ -120,6 +120,7 @@ properties:
> > - const: mediatek,mt8183
> > - description: Google Krane (Lenovo IdeaPad Duet, 10e,...)
> > items:
> > + - const: google,krane-sku0
> > - const: google,krane-sku176
> > - const: google,krane
> > - const: mediatek,mt8183
>
> This says you must have all 4 compatible strings in the order listed.
> That doesn't match your dts. I assume you want the first 2 under an
> 'enum' so there's 3 strings with the first one being sku0 or sku176?
>
Right. I'll fix in the next version. Thanks
> Rob

\
 
 \ /
  Last update: 2021-01-13 07:26    [W:0.050 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site