Messages in this thread | | | Subject | Re: [PATCH 7/9] media: ti-vpe: Do not zero reserved fields | From | Kieran Bingham <> | Date | Tue, 12 Jan 2021 11:12:36 +0000 |
| |
Hi Ricardo,
On 11/01/2021 14:54, Ricardo Ribalda wrote: > Core code already clears reserved fields of struct > v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero > v4l2_plane_pix_format reserved fields").
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Cc: Benoit Parrot <bparrot@ti.com> > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> > --- > drivers/media/platform/ti-vpe/vpe.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c > index 779dd74b82d0..10251b787674 100644 > --- a/drivers/media/platform/ti-vpe/vpe.c > +++ b/drivers/media/platform/ti-vpe/vpe.c > @@ -1683,7 +1683,6 @@ static int __vpe_try_fmt(struct vpe_ctx *ctx, struct v4l2_format *f, > } > } > > - memset(pix->reserved, 0, sizeof(pix->reserved)); > for (i = 0; i < pix->num_planes; i++) { > plane_fmt = &pix->plane_fmt[i]; > depth = fmt->vpdma_fmt[i]->depth; > @@ -1713,7 +1712,6 @@ static int __vpe_try_fmt(struct vpe_ctx *ctx, struct v4l2_format *f, > plane_fmt->bytesperline * > depth) >> 3; > } > - memset(plane_fmt->reserved, 0, sizeof(plane_fmt->reserved)); > } > > return 0; >
| |