lkml.org 
[lkml]   [2021]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 07/11] kasan: add compiler barriers to KUNIT_EXPECT_KASAN_FAIL
    On Tue, Jan 5, 2021 at 7:28 PM Andrey Konovalov <andreyknvl@google.com> wrote:
    >
    > It might not be obvious to the compiler that the expression must be
    > executed between writing and reading to fail_data. In this case, the
    > compiler might reorder or optimize away some of the accesses, and
    > the tests will fail.

    Have you seen this happen in practice?
    Are these accesses to fail_data that are optimized (in which case we
    could make it volatile), or some part of the expression?
    Note that compiler barriers won't probably help against removing
    memory accesses, they only prevent reordering.

    > + barrier(); \
    > expression; \
    > + barrier(); \

    The need for barriers is not obvious to the reader, so a comment in
    the code clarifying that would be nice.

    \
     
     \ /
      Last update: 2021-01-12 09:20    [W:4.831 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site