lkml.org 
[lkml]   [2021]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 17/92] atm: idt77252: call pci_disable_device() on error path
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 8df66af5c1e5f80562fe728db5ec069b21810144 ]

    This error path needs to disable the pci device before returning.

    Fixes: ede58ef28e10 ("atm: remove deprecated use of pci api")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Link: https://lore.kernel.org/r/X93dmC4NX0vbTpGp@mwanda
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/atm/idt77252.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/atm/idt77252.c
    +++ b/drivers/atm/idt77252.c
    @@ -3606,7 +3606,7 @@ static int idt77252_init_one(struct pci_

    if ((err = dma_set_mask_and_coherent(&pcidev->dev, DMA_BIT_MASK(32)))) {
    printk("idt77252: can't enable DMA for PCI device at %s\n", pci_name(pcidev));
    - return err;
    + goto err_out_disable_pdev;
    }

    card = kzalloc(sizeof(struct idt77252_dev), GFP_KERNEL);

    \
     
     \ /
      Last update: 2021-01-11 14:48    [W:4.159 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site