Messages in this thread | | | Subject | Re: [PATCH] drm/hisilicon: Use drm_crtc_mask() | From | Thomas Zimmermann <> | Date | Mon, 11 Jan 2021 08:49:35 +0100 |
| |
Hi
Am 11.01.21 um 04:30 schrieb Tian Tao: > Use drm_crtc_mask() where appropriate. > > Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Looks like the right thing to do.
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Best regards Thomas
> --- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c > index c76f996..1c5f2fa 100644 > --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c > +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c > @@ -96,6 +96,7 @@ int hibmc_vdac_init(struct hibmc_drm_private *priv) > struct drm_device *dev = &priv->dev; > struct hibmc_connector *hibmc_connector = &priv->connector; > struct drm_encoder *encoder = &priv->encoder; > + struct drm_crtc *crtc = &priv->crtc; > struct drm_connector *connector = &hibmc_connector->base; > int ret; > > @@ -105,7 +106,7 @@ int hibmc_vdac_init(struct hibmc_drm_private *priv) > return ret; > } > > - encoder->possible_crtcs = 0x1; > + encoder->possible_crtcs = drm_crtc_mask(crtc); > ret = drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_DAC); > if (ret) { > drm_err(dev, "failed to init encoder: %d\n", ret); >
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
[unhandled content-type:application/pgp-signature] | |