lkml.org 
[lkml]   [2021]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 002/145] iavf: fix double-release of rtnl_lock
    Date
    From: Jakub Kicinski <kuba@kernel.org>

    [ Upstream commit f1340265726e0edf8a8cef28e665b28ad6302ce9 ]

    This code does not jump to exit on an error in iavf_lan_add_device(),
    so the rtnl_unlock() from the normal path will follow.

    Fixes: b66c7bc1cd4d ("iavf: Refactor init state machine")
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com>
    Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
    Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/intel/iavf/iavf_main.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
    +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
    @@ -1834,11 +1834,9 @@ static int iavf_init_get_resources(struc
    netif_tx_stop_all_queues(netdev);
    if (CLIENT_ALLOWED(adapter)) {
    err = iavf_lan_add_device(adapter);
    - if (err) {
    - rtnl_unlock();
    + if (err)
    dev_info(&pdev->dev, "Failed to add VF to client API service list: %d\n",
    err);
    - }
    }
    dev_info(&pdev->dev, "MAC address: %pM\n", adapter->hw.mac.addr);
    if (netdev->features & NETIF_F_GRO)

    \
     
     \ /
      Last update: 2021-01-11 14:16    [W:4.100 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site