Messages in this thread | | | From | Felipe Balbi <> | Subject | Re: [PATCH] usb/gadget: f_midi: Replace tasklet with work | Date | Mon, 11 Jan 2021 09:28:29 +0200 |
| |
Hi,
Davidlohr Bueso <dave@stgolabs.net> writes: > Currently a tasklet is used to transmit input substream buffer > data. However, tasklets have long been deprecated as being too > heavy on the system by running in irq context - and this is not > a performance critical path. If a higher priority process wants > to run, it must wait for the tasklet to finish before doing so. > > Deferring work to a workqueue and executing in process context > should be fine considering the callback already does > f_midi_do_transmit() under the transmit_lock and thus changes in > semantics are ok regarding concurrency - tasklets being serialized > against itself. > > Cc: Takashi Iwai <tiwai@suse.de> > Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
Acked-by: Felipe Balbi <balbi@kernel.org>
-- balbi [unhandled content-type:application/pgp-signature]
| |