lkml.org 
[lkml]   [2021]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 41/92] CDC-NCM: remove "connected" log message
    Date
    From: Roland Dreier <roland@kernel.org>

    [ Upstream commit 59b4a8fa27f5a895582ada1ae5034af7c94a57b5 ]

    The cdc_ncm driver passes network connection notifications up to
    usbnet_link_change(), which is the right place for any logging.
    Remove the netdev_info() duplicating this from the driver itself.

    This stops devices such as my "TRENDnet USB 10/100/1G/2.5G LAN"
    (ID 20f4:e02b) adapter from spamming the kernel log with

    cdc_ncm 2-2:2.0 enp0s2u2c2: network connection: connected

    messages every 60 msec or so.

    Signed-off-by: Roland Dreier <roland@kernel.org>
    Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Link: https://lore.kernel.org/r/20201224032116.2453938-1-roland@kernel.org
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/usb/cdc_ncm.c | 3 ---
    1 file changed, 3 deletions(-)

    --- a/drivers/net/usb/cdc_ncm.c
    +++ b/drivers/net/usb/cdc_ncm.c
    @@ -1625,9 +1625,6 @@ static void cdc_ncm_status(struct usbnet
    * USB_CDC_NOTIFY_NETWORK_CONNECTION notification shall be
    * sent by device after USB_CDC_NOTIFY_SPEED_CHANGE.
    */
    - netif_info(dev, link, dev->net,
    - "network connection: %sconnected\n",
    - !!event->wValue ? "" : "dis");
    usbnet_link_change(dev, !!event->wValue, 0);
    break;


    \
     
     \ /
      Last update: 2021-01-11 14:13    [W:4.057 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site