lkml.org 
[lkml]   [2021]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] usb: cdnsp: fixes undefined reference to cdns_remove
Date

>
> On 1/11/21 6:42 AM, Pawel Laszczak wrote:
> > Patch fixes the following errors:
> > ld: drivers/usb/cdns3/cdnsp-pci.o: in function `cdnsp_pci_remove':
> > cdnsp-pci.c:(.text+0x80): undefined reference to `cdns_remove'
> > ld: drivers/usb/cdns3/cdnsp-pci.o: in function `cdnsp_pci_probe':
> > cdnsp-pci.c:(.text+0x34c): undefined reference to `cdns_init'
> >
> > Issue occurs for USB/CDNS3/CDNSP kernel configuration:
> > CONFIG_USB=m
> > CONFIG_USB_CDNS_SUPPORT=y
> > CONFIG_USB_CDNS3=m
> > CONFIG_USB_CDNS3_PCI_WRAP=m
> > CONFIG_USB_CDNSP_PCI=y
> >
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>
> Yep, that works. Thanks.
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
>

Applied it, thanks.

Peter
>
> > ---
> > drivers/usb/cdns3/Makefile | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/usb/cdns3/Makefile b/drivers/usb/cdns3/Makefile
> > index 3f9b7fa8a594..be906910f98b 100644
> > --- a/drivers/usb/cdns3/Makefile
> > +++ b/drivers/usb/cdns3/Makefile
> > @@ -26,7 +26,11 @@ obj-$(CONFIG_USB_CDNS3_TI) +=
> cdns3-ti.o
> > obj-$(CONFIG_USB_CDNS3_IMX) += cdns3-imx.o
> >
> > cdnsp-udc-pci-y := cdnsp-pci.o
> > +ifeq ($(CONFIG_USB),m)
> > +obj-m += cdnsp-udc-pci.o
> > +else
> > obj-$(CONFIG_USB_CDNSP_PCI) += cdnsp-udc-pci.o
> > +endif
> > cdnsp-udc-pci-$(CONFIG_USB_CDNSP_GADGET) += cdnsp-ring.o
> cdnsp-gadget.o \
> > cdnsp-mem.o cdnsp-ep0.o
> >
> >
>
>
> --
> ~Randy

\
 
 \ /
  Last update: 2021-01-12 02:58    [W:0.056 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site