lkml.org 
[lkml]   [2021]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [EXT] [PATCH] scsi: qedf: style: Simplify bool comparison
Date
Hi,
Thanks for a patch.

> -----Original Message-----
> From: YANG LI <abaci-bugfix@linux.alibaba.com>
> Sent: Monday, January 11, 2021 2:59 PM
> To: jejb@linux.ibm.com
> Cc: martin.petersen@oracle.com; Saurav Kashyap <skashyap@marvell.com>;
> Javed Hasan <jhasan@marvell.com>; GR-QLogic-Storage-Upstream <GR-
> QLogic-Storage-Upstream@marvell.com>; linux@armlinux.org.uk; linux-
> scsi@vger.kernel.org; linux-kernel@vger.kernel.org; netdev@vger.kernel.org;
> YANG LI <abaci-bugfix@linux.alibaba.com>
> Subject: [EXT] [PATCH] scsi: qedf: style: Simplify bool comparison
>
> External Email
>
> ----------------------------------------------------------------------
> Fix the following coccicheck warning:
> ./drivers/scsi/qedf/qedf_main.c:3716:5-31: WARNING: Comparison to bool
>
> Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
> Reported-by: Abaci Robot<abaci@linux.alibaba.com>
> ---
> drivers/scsi/qedf/qedf_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
> index 46d185c..cec27f2 100644
> --- a/drivers/scsi/qedf/qedf_main.c
> +++ b/drivers/scsi/qedf/qedf_main.c
> @@ -3713,7 +3713,7 @@ static void __qedf_remove(struct pci_dev *pdev, int
> mode)
> else
> fc_fabric_logoff(qedf->lport);
>
> - if (qedf_wait_for_upload(qedf) == false)
> + if (!qedf_wait_for_upload(qedf))
> QEDF_ERR(&qedf->dbg_ctx, "Could not upload all sessions.\n");
>
> #ifdef CONFIG_DEBUG_FS
> --
> 1.8.3.1

Acked-by: Saurav Kashyap <skashyap@marvell.com>

\
 
 \ /
  Last update: 2021-01-11 10:49    [W:1.067 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site