lkml.org 
[lkml]   [2021]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v3, 08/15] drm/mediatek: check if fb is null
    Hi, Yongqiang:

    Yongqiang Niu <yongqiang.niu@mediatek.com> 於 2021年1月11日 週一 下午3:48寫道:
    >
    > It's possible that state->base.fb is null. Add a check before access its
    > format.

    Applied to mediatek-drm-next [1], thanks.

    [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

    Regards,
    Chun-Kuang.

    >
    > Fixes: b6b1bb980ec4 ( drm/mediatek: Turn off Alpha bit when plane format has no alpha)
    > Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
    > ---
    > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
    > index 4934bee..8e7f494 100644
    > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
    > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
    > @@ -279,7 +279,7 @@ static void mtk_ovl_layer_config(struct mtk_ddp_comp *comp, unsigned int idx,
    > }
    >
    > con = ovl_fmt_convert(ovl, fmt);
    > - if (state->base.fb->format->has_alpha)
    > + if (state->base.fb && state->base.fb->format->has_alpha)
    > con |= OVL_CON_AEN | OVL_CON_ALPHA;
    >
    > if (pending->rotation & DRM_MODE_REFLECT_Y) {
    > --
    > 1.8.1.1.dirty
    > _______________________________________________
    > Linux-mediatek mailing list
    > Linux-mediatek@lists.infradead.org
    > http://lists.infradead.org/mailman/listinfo/linux-mediatek

    \
     
     \ /
      Last update: 2021-01-12 01:38    [W:4.534 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site