lkml.org 
[lkml]   [2021]   [Jan]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH RESEND v2 2/2] Add support for Realtek RTL838x/RTL839x SoC SPI controllers
From
Date
On 12/31/20 3:23 PM, Lukas Wunner wrote:
> On Wed, Dec 30, 2020 at 12:19:04AM +0100, Bert Vermeulen wrote:
>> +static inline void wait_ready(struct rtspi *rtspi)
>> +{
>> + while (!(readl(REG(RTL8380_SPI_SFCSR)) & RTL8380_SPI_SFCSR_RDY))
>> + ;
>> +}
>
> I'd suggest calling cpu_relax() in the loop's body.
>
>
>> + err = devm_spi_register_controller(&pdev->dev, ctrl);
>
> Since you're invoking devm_spi_register_controller() on probe,
> the controller must not be unregistered explicitly on remove.
> So the ->remove hook can be dropped altogether:
>
>> +static int realtek_spi_remove(struct platform_device *pdev)
>> +{
>> + struct spi_controller *ctrl = platform_get_drvdata(pdev);
>> +
>> + spi_unregister_controller(ctrl);
>> +
>> + return 0;
>> +}
> [...]
>> + .remove = realtek_spi_remove,
>
> The ->probe hook otherwise LGTM.

Thanks Lukas, will fix those issues.


--
Bert Vermeulen
bert@biot.com

\
 
 \ /
  Last update: 2021-01-01 12:30    [W:1.576 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site