Messages in this thread | | | Date | Wed, 9 Sep 2020 12:23:45 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 1/1] USB: PHY: JZ4770: Fix uninitialized value written to HW register |
| |
Hi!
> >>> - reg = USBPCR_IDPULLUP_OTG | USBPCR_VBUSVLDEXT > >>> | USBPCR_TXPREEMPHTUNE | > >>> + return USBPCR_IDPULLUP_OTG | USBPCR_VBUSVLDEXT | > >>> USBPCR_TXPREEMPHTUNE | > >>> USBPCR_COMMONONN | USBPCR_POR; > >>> - writel(reg, priv->base + REG_USBPCR_OFFSET); > >> > >> not a bug fix > > > > Well, if you don't like my bug fix, next time wait for my Reviewed-by. > > why so angry? Take a break every once in a while. Besides, someone else > already sent the oneliner before you ;-)
Your behaviour is pretty good explanation for angry people on the mailing list.
Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |