Messages in this thread | | | Date | Wed, 9 Sep 2020 11:07:36 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v3 1/2] leds: pwm: Allow automatic labels for DT based devices |
| |
Hi!
> pwm_init_state(led_data->pwm, &led_data->pwmstate); > > - ret = devm_led_classdev_register(dev, &led_data->cdev); > + if (fwnode) { > + init_data.fwnode = fwnode; > + ret = devm_led_classdev_register_ext(dev, &led_data->cdev, > + &init_data); > + } else { > + ret = devm_led_classdev_register(dev, &led_data->cdev); > + }
Can you always use _ext version, even with null fwnode? If not, can you fix the core to accept that? Having that conditional in driver is ugly.
Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |