| Subject | Re: [PATCH 06/19] swim: simplify media change handling | From | Hannes Reinecke <> | Date | Wed, 9 Sep 2020 09:09:34 +0200 |
| |
On 9/8/20 4:53 PM, Christoph Hellwig wrote: > floppy_revalidate mostly duplicates work already done in floppy_open > despite only beeing called from floppy_open. Remove the function and > just clear the ->ejected flag directly under the right condition. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> > --- > drivers/block/swim.c | 24 ++---------------------- > 1 file changed, 2 insertions(+), 22 deletions(-) > What a convoluted driver.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
|