lkml.org 
[lkml]   [2020]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next + leds v2 2/7] leds: add generic API for LEDs that can be controlled by hardware
    Hi!

    > > > Many an ethernet PHY (and other chips) supports various HW control modes
    > > > for LEDs connected directly to them.
    > >
    > > I guess this should be
    > >
    > > "Many ethernet PHYs (and other chips) support various HW control modes
    > > for LEDs connected directly to them."
    > >
    >
    > I guess it is older English, used mainly in poetry, but I read it in
    > works of contemporary fiction as well. As far as I could find, it is still
    > actually gramatically correct.
    > https://idioms.thefreedictionary.com/many+an
    > https://en.wiktionary.org/wiki/many_a
    > But I will change it if you insist on it.

    Okay, you got me.

    > > > +Contact: Marek Behún <marek.behun@nic.cz>
    > > > + linux-leds@vger.kernel.org
    > > > +Description: (W) Set the HW control mode of this LED. The various available HW control modes
    > > > + are specific per device to which the LED is connected to and per LED itself.
    > > > + (R) Show the available HW control modes and the currently selected one.
    > >
    > > 80 columns :-) (and please fix that globally, at least at places where
    > > it is easy, like comments).
    > >
    >
    > Linux is at 100 columns now since commit bdc48fa11e46, commited by
    > Linus. See
    > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/scripts/checkpatch.pl?h=v5.9-rc4&id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144
    > There was actually an article about this on Phoronix, I think.

    It is not. Checkpatch no longer warns about it, but 80 columns is
    still preffered, see Documentation/process/coding-style.rst . Plus,
    you want me to take the patch, not Linus.

    > > > +extern struct led_hw_trigger_type hw_control_led_trig_type;
    > > > +extern struct led_trigger hw_control_led_trig;
    > > > +
    > > > +#else /* !IS_ENABLED(CONFIG_LEDS_HW_CONTROLLED) */
    > >
    > > CONFIG_LEDS_HWC? Or maybe CONFIG_LEDTRIG_HW?
    >
    > The second option looks more reasonable to me, if we move to
    > drivers/leds/trigger.

    Ok :-).

    Best regards,
    Pavel

    \
     
     \ /
      Last update: 2020-09-09 23:40    [W:2.879 / U:0.648 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site