lkml.org 
[lkml]   [2020]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] selftests/lkdtm: Use "comm" instead of "diff" for dmesg
From
Date
On 9/9/20 2:49 PM, Shuah Khan wrote:
> On 9/9/20 1:49 PM, Kees Cook wrote:
>>
>> On Fri, Jun 26, 2020 at 01:59:43PM -0700, Kees Cook wrote:
>>> Instead of full GNU diff (which smaller boot environments may not have),
>>> use "comm" which is more available.
>>>
>>> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>>> Link:
>>> https://lore.kernel.org/lkml/CA+G9fYtHP+Gg+BrR_GkBMxu2oOi-_e9pATtpb6TVRswv1G1r1Q@mail.gmail.com
>>>
>>> Fixes: f131d9edc29d ("selftests/lkdtm: Don't clear dmesg when running
>>> tests")
>>> Signed-off-by: Kees Cook <keescook@chromium.org>
>>
>> Shuah, this really needs to land to fix lkdtm tests on busybox. Can
>> you add this to -next? (Or is it better to direct this to Greg for the
>> lkdtm tree?)
>>
>
> Kees, Thanks for the ping. I can queue this up in -next
>
> Greg, would you like me to take this through selftest tree?
>
> In case you want to take this through lkdtm tree:
>
> Acked-by: Shuah Khan <skhan@linuxfoundation.org>
>

Kees,

Just saw your reply. Will wait for v2.

thanks,
-- Shuah

\
 
 \ /
  Last update: 2020-09-09 23:19    [W:0.059 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site