lkml.org 
[lkml]   [2020]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC 03/10] phy: hisilicon: phy-hi3670-usb3: use a consistent namespace
On Fri, Sep 4, 2020 at 4:23 AM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:
>
> Rename hikey970 to hi3670, in order to use a namespace
> similar to hi3660 driver.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> .../bindings/phy/phy-hi3670-usb3.txt | 4 +-

Bindings should be a separate patch.

> drivers/phy/hisilicon/phy-hi3670-usb3.c | 98 +++++++++----------
> 2 files changed, 51 insertions(+), 51 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/phy-hi3670-usb3.txt b/Documentation/devicetree/bindings/phy/phy-hi3670-usb3.txt
> index 4cb02612ff23..2fb27cb8beaf 100644
> --- a/Documentation/devicetree/bindings/phy/phy-hi3670-usb3.txt
> +++ b/Documentation/devicetree/bindings/phy/phy-hi3670-usb3.txt
> @@ -2,7 +2,7 @@ Hisilicon Kirin970 usb PHY
> -----------------------
>
> Required properties:
> -- compatible: should be "hisilicon,kirin970-usb-phy"
> +- compatible: should be "hisilicon,hi3670-usb-phy"

Unless this is unused, we can't just change it. It's an ABI.

> - #phy-cells: must be 0
> - hisilicon,pericrg-syscon: phandle of syscon used to control phy.
> - hisilicon,pctrl-syscon: phandle of syscon used to control phy.
> @@ -14,7 +14,7 @@ Refer to phy/phy-bindings.txt for the generic PHY binding properties
>
> Example:
> usb_phy: usbphy {
> - compatible = "hisilicon,kirin970-usb-phy";
> + compatible = "hisilicon,hi3670-usb-phy";
> #phy-cells = <0>;
> hisilicon,pericrg-syscon = <&crg_ctrl>;
> hisilicon,pctrl-syscon = <&pctrl>;

\
 
 \ /
  Last update: 2020-09-09 22:16    [W:0.139 / U:1.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site