lkml.org 
[lkml]   [2020]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/7] cpufreq: qcom-hw: Use devm_platform_ioremap_resource() to simplify code
On 0908, Viresh Kumar wrote:
> On 08-09-20, 13:27, Manivannan Sadhasivam wrote:
> > devm_platform_ioremap_resource() is the combination of
> > platform_get_resource() and devm_ioremap_resource(). Hence, use it to
> > simplify the code a bit.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > drivers/cpufreq/qcom-cpufreq-hw.c | 11 +++--------
> > 1 file changed, 3 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c
> > index c3c397cc3dc6..6eeeb2bd4dfa 100644
> > --- a/drivers/cpufreq/qcom-cpufreq-hw.c
> > +++ b/drivers/cpufreq/qcom-cpufreq-hw.c
> > @@ -307,7 +307,6 @@ static int qcom_cpufreq_hw_cpu_init(struct cpufreq_policy *policy)
> > struct of_phandle_args args;
> > struct device_node *cpu_np;
> > struct device *cpu_dev;
> > - struct resource *res;
> > void __iomem *base;
> > struct qcom_cpufreq_data *data;
> > const struct of_device_id *match;
> > @@ -333,13 +332,9 @@ static int qcom_cpufreq_hw_cpu_init(struct cpufreq_policy *policy)
> >
> > index = args.args[0];
> >
> > - res = platform_get_resource(pdev, IORESOURCE_MEM, index);
> > - if (!res)
> > - return -ENODEV;
> > -
> > - base = devm_ioremap(dev, res->start, resource_size(res));
> > - if (!base)
> > - return -ENOMEM;
> > + base = devm_platform_ioremap_resource(pdev, index);
> > + if (IS_ERR(base))
> > + return PTR_ERR(base);
> >
> > data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
> > if (!data) {
>
> Keep such patches at the top, so they could be independently applied.
>

Okay.

Thanks,
Mani

> --
> viresh

\
 
 \ /
  Last update: 2020-09-08 13:16    [W:0.051 / U:2.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site