Messages in this thread | | | Date | Tue, 8 Sep 2020 09:57:53 +0200 | From | Daniel Wagner <> | Subject | Re: [PATCH v2 4/4] qla2xxx: Handle incorrect entry_type entries |
| |
Hi Arun,
On Mon, Sep 07, 2020 at 11:47:48PM -0700, Arun Easi wrote: > Could you drop the above comment about firmware, as it is speculation at > this point?
Sure, no problem.
> It'd be best to take a chip reset path, rather than assuming the > packet is good and having the appropriate handler called (hacky). > An approach similar to the one done at the beginning of > qla2x00_get_sp_from_handle() is what I had in mind.
Ok, agreed a reset is probably the safest choice.
> I'd have preferred a common approach across the different IOCB types > as an attempt to harden the code, but that will be a little more > involved work. This looks ok.
Yes, I was pondering on it but I don't know enough to really come up with something reasonable. Currently our customers report only this hickup. So this is really only a partial workaround.
Thanks, Daniel
| |