Messages in this thread | | | From | Edwin Peer <> | Date | Tue, 8 Sep 2020 13:49:20 -0700 | Subject | Re: [PATCH 4.19 34/88] bnxt_en: fix HWRM error when querying VF temperature |
| |
On Tue, Sep 8, 2020 at 12:47 PM Pavel Machek <pavel@denx.de> wrote:
> > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c > > @@ -6836,16 +6836,19 @@ static ssize_t bnxt_show_temp(struct device *dev, > ... > > - return sprintf(buf, "%u\n", temp); > > + if (len) > > + return len; > > + > > + return sprintf(buf, "unknown\n"); > > } > > We normally just do return -EIO (or other error code) in such cases.
That does seem more appropriate. I will fix it, thank you.
Regards, Edwin Peer
| |