lkml.org 
[lkml]   [2020]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V3 3/3] pinctrl: imx: Support building i.MX pinctrl core driver as module
Date


> Subject: Re: [PATCH V3 3/3] pinctrl: imx: Support building i.MX pinctrl core
> driver as module
>
> On Tue, Sep 8, 2020 at 9:20 AM Anson Huang <Anson.Huang@nxp.com>
> wrote:
>
> > # SPDX-License-Identifier: GPL-2.0-only config PINCTRL_IMX
> > - bool
> > + tristate "IMX pinctrl core driver"
> > + depends on OF
> > select GENERIC_PINCTRL_GROUPS
> > select GENERIC_PINMUX_FUNCTIONS
> > select GENERIC_PINCONF
>
> I don't see why you need to make this option user-visible when it is already
> selected by the drivers that need it. Wouldn't it be enough to change the 'bool'
> to 'tristate' without adding a prompt?

Make sense, so it is same for PINCTRL_IMX_SCU, right?

Anson

\
 
 \ /
  Last update: 2020-09-08 09:34    [W:1.300 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site