lkml.org 
[lkml]   [2020]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 060/186] net: arc_emac: Fix memleak in arc_mdio_probe
    Date
    From: Dinghao Liu <dinghao.liu@zju.edu.cn>

    [ Upstream commit e2d79cd8875fa8c3cc7defa98a8cc99a1ed0c62f ]

    When devm_gpiod_get_optional() fails, bus should be
    freed just like when of_mdiobus_register() fails.

    Fixes: 1bddd96cba03d ("net: arc_emac: support the phy reset for emac driver")
    Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
    Reviewed-by: Andrew Lunn <andrew@lunn.ch>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/arc/emac_mdio.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/ethernet/arc/emac_mdio.c b/drivers/net/ethernet/arc/emac_mdio.c
    index 0187dbf3b87df..54cdafdd067db 100644
    --- a/drivers/net/ethernet/arc/emac_mdio.c
    +++ b/drivers/net/ethernet/arc/emac_mdio.c
    @@ -153,6 +153,7 @@ int arc_mdio_probe(struct arc_emac_priv *priv)
    if (IS_ERR(data->reset_gpio)) {
    error = PTR_ERR(data->reset_gpio);
    dev_err(priv->dev, "Failed to request gpio: %d\n", error);
    + mdiobus_free(bus);
    return error;
    }

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-09-08 21:23    [W:4.094 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site