lkml.org 
[lkml]   [2020]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 135/186] ALSA: ca0106: fix error code handling
    Date
    From: Tong Zhang <ztong0001@gmail.com>

    commit ee0761d1d8222bcc5c86bf10849dc86cf008557c upstream.

    snd_ca0106_spi_write() returns 1 on error, snd_ca0106_pcm_power_dac()
    is returning the error code directly, and the caller is expecting an
    negative error code

    Signed-off-by: Tong Zhang <ztong0001@gmail.com>
    Cc: <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/20200824224541.1260307-1-ztong0001@gmail.com
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/pci/ca0106/ca0106_main.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/sound/pci/ca0106/ca0106_main.c
    +++ b/sound/pci/ca0106/ca0106_main.c
    @@ -537,7 +537,8 @@ static int snd_ca0106_pcm_power_dac(stru
    else
    /* Power down */
    chip->spi_dac_reg[reg] |= bit;
    - return snd_ca0106_spi_write(chip, chip->spi_dac_reg[reg]);
    + if (snd_ca0106_spi_write(chip, chip->spi_dac_reg[reg]) != 0)
    + return -ENXIO;
    }
    return 0;
    }

    \
     
     \ /
      Last update: 2020-09-08 21:20    [W:4.128 / U:0.432 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site