lkml.org 
[lkml]   [2020]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 097/186] net: bcmgenet: fix mask check in bcmgenet_validate_flow()
    Date
    From: Denis Efremov <efremov@linux.com>

    [ Upstream commit 1996cf46e4673a25ef2478eb266714f409a98221 ]

    VALIDATE_MASK(eth_mask->h_source) is checked twice in a row in
    bcmgenet_validate_flow(). Add VALIDATE_MASK(eth_mask->h_dest)
    instead.

    Fixes: 3e370952287c ("net: bcmgenet: add support for ethtool rxnfc flows")
    Signed-off-by: Denis Efremov <efremov@linux.com>
    Acked-by: Doug Berger <opendmb@gmail.com>
    Acked-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
    index e471b14fc6e98..f0074c873da3b 100644
    --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
    +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
    @@ -1364,7 +1364,7 @@ static int bcmgenet_validate_flow(struct net_device *dev,
    case ETHER_FLOW:
    eth_mask = &cmd->fs.m_u.ether_spec;
    /* don't allow mask which isn't valid */
    - if (VALIDATE_MASK(eth_mask->h_source) ||
    + if (VALIDATE_MASK(eth_mask->h_dest) ||
    VALIDATE_MASK(eth_mask->h_source) ||
    VALIDATE_MASK(eth_mask->h_proto)) {
    netdev_err(dev, "rxnfc: Unsupported mask\n");
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-09-08 21:18    [W:4.096 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site