lkml.org 
[lkml]   [2020]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 07/10] phy: qcom-qmp: Add support for DP in USB3+DP combo phy
From
Date
Quoting Jonathan Marek (2020-09-03 16:26:39)
> On 9/2/20 7:02 PM, Stephen Boyd wrote:
>
> > +static int qcom_qmp_phy_configure_dp_phy(struct qmp_phy *qphy)
> > +{
[...]
> > + writel(0x05, qphy->pcs + QSERDES_V3_DP_PHY_CFG);
> > + writel(0x01, qphy->pcs + QSERDES_V3_DP_PHY_CFG);
> > + writel(0x09, qphy->pcs + QSERDES_V3_DP_PHY_CFG);
> > +
> > + writel(0x20, qphy->serdes + QSERDES_COM_RESETSM_CNTRL);
>
> Should be QSERDES_V3_COM_RESETSM_CNTRL and not
> QSERDES_COM_RESETSM_CNTRL, which is for older PHY versions.
>

Thanks! Fixed it.

\
 
 \ /
  Last update: 2020-09-08 20:46    [W:1.235 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site