Messages in this thread | | | Subject | Re: [PATCH v2 07/10] phy: qcom-qmp: Add support for DP in USB3+DP combo phy | From | Stephen Boyd <> | Date | Tue, 08 Sep 2020 11:42:09 -0700 |
| |
Quoting Jonathan Marek (2020-09-03 16:26:39) > On 9/2/20 7:02 PM, Stephen Boyd wrote: > > > +static int qcom_qmp_phy_configure_dp_phy(struct qmp_phy *qphy) > > +{ [...] > > + writel(0x05, qphy->pcs + QSERDES_V3_DP_PHY_CFG); > > + writel(0x01, qphy->pcs + QSERDES_V3_DP_PHY_CFG); > > + writel(0x09, qphy->pcs + QSERDES_V3_DP_PHY_CFG); > > + > > + writel(0x20, qphy->serdes + QSERDES_COM_RESETSM_CNTRL); > > Should be QSERDES_V3_COM_RESETSM_CNTRL and not > QSERDES_COM_RESETSM_CNTRL, which is for older PHY versions. >
Thanks! Fixed it.
| |