lkml.org 
[lkml]   [2020]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 31/88] bnxt_en: Dont query FW when netif_running() is false.
    Date
    From: Pavan Chebbi <pavan.chebbi@broadcom.com>

    [ Upstream commit c1c2d77408022a398a1a7c51cf20488c922629de ]

    In rare conditions like two stage OS installation, the
    ethtool's get_channels function may be called when the
    device is in D3 state, leading to uncorrectable PCI error.
    Check netif_running() first before making any query to FW
    which involves writing to BAR.

    Fixes: db4723b3cd2d ("bnxt_en: Check max_tx_scheduler_inputs value from firmware.")
    Signed-off-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
    Signed-off-by: Michael Chan <michael.chan@broadcom.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
    index 63730e449e088..14fe4f9f24b88 100644
    --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
    +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
    @@ -471,7 +471,7 @@ static void bnxt_get_channels(struct net_device *dev,
    int max_tx_sch_inputs;

    /* Get the most up-to-date max_tx_sch_inputs. */
    - if (BNXT_NEW_RM(bp))
    + if (netif_running(dev) && BNXT_NEW_RM(bp))
    bnxt_hwrm_func_resc_qcaps(bp, false);
    max_tx_sch_inputs = hw_resc->max_tx_sch_inputs;

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-09-08 20:39    [W:4.277 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site