Messages in this thread | | | Date | Mon, 7 Sep 2020 14:51:59 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH 16/23] gpio: mockup: refactor the module init function |
| |
On Mon, Sep 07, 2020 at 01:05:54PM +0200, Bartosz Golaszewski wrote: > On Fri, Sep 4, 2020 at 6:57 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > On Fri, Sep 04, 2020 at 05:45:40PM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > > > This is in preparation for dynamically created chips. > > > > > > Let's split out the code that can be reused when creating chips at > > > run-time. Let's also move the code preparing the device properties into > > > a separate routine. This has the advantage of simplifying the error > > > handling. > > > > Almost all contents of this patch should go to proposed helper as I mentioned > > before. Will make this patch quite small and understandable.
> Sorry, I'm not sure what you're referring to.
I meant if you move changes done here to the patch where I complained about indentation you might have better series. Have you considered that?
-- With Best Regards, Andy Shevchenko
| |