lkml.org 
[lkml]   [2020]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subjectwatchdog: sp5100_tco support for AMD V/R/E series
    Date
    Hi all,

    Arsalan reported that the upstream driver for sp5100_tco does not work
    for embedded Ryzen. Meanwhile, I was able to confirm that on an R1505G:

    [ 11.607251] sp5100_tco: SP5100/SB800 TCO WatchDog Timer Driver
    [ 11.607337] sp5100-tco sp5100-tco: Using 0xfed80b00 for watchdog MMIO address
    [ 11.607344] sp5100-tco sp5100-tco: Watchdog hardware is disabled

    ..and fix it:

    diff --git a/drivers/watchdog/sp5100_tco.c b/drivers/watchdog/sp5100_tco.c
    index 85e9664318c9..5482154fde42 100644
    --- a/drivers/watchdog/sp5100_tco.c
    +++ b/drivers/watchdog/sp5100_tco.c
    @@ -193,7 +193,8 @@ static void tco_timer_enable(struct sp5100_tco *tco)
    /* Set the Watchdog timer resolution to 1 sec and enable */
    sp5100_tco_update_pm_reg8(EFCH_PM_DECODEEN3,
    ~EFCH_PM_WATCHDOG_DISABLE,
    - EFCH_PM_DECODEEN_SECOND_RES);
    + EFCH_PM_DECODEEN_SECOND_RES |
    + EFCH_PM_DECODEEN_WDT_TMREN);
    break;
    }
    }
    Does anyone have an idea if such unconditional setting could be
    problematic on older/different efch? We probe for that bit in
    sp5100_tco_setupdevice but we never set it so far.

    I'm missing specs...

    Thanks,
    Jan

    --
    Siemens AG, Corporate Technology, CT RDA IOT SES-DE
    Corporate Competence Center Embedded Linux

    \
     
     \ /
      Last update: 2020-09-07 13:27    [W:3.176 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site