Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Mon, 7 Sep 2020 12:53:51 +0200 | Subject | Re: [PATCH 05/23] gpiolib: unexport devprop_gpiochip_set_names() |
| |
On Fri, Sep 4, 2020 at 6:42 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Fri, Sep 04, 2020 at 05:45:29PM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > Now that devprop_gpiochip_set_names() is only used in a single place > > inside drivers/gpio/gpiolib.c, there's no need anymore for it to be > > exported or to even live in its own source file. Pull this function into > > the core source file for gpiolib. > > I have mixed feelings about this. We may simply unexport and attach object file > to gpiolib.o. Would it be expected to see more functions in this file in the > future? >
This file was created for this function alone over 4 years ago and never saw any new routines. Personally I think there's no reason to keep a single helper in its own file. We usually only split big chunks of code out of gpiolib.c.
Bart
| |