Messages in this thread | | | From | Michel Dänzer <> | Subject | Re: [PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups. | Date | Mon, 7 Sep 2020 12:29:22 +0200 |
| |
On 2020-09-07 9:55 a.m., Daniel Vetter wrote: > On Thu, Aug 06, 2020 at 12:52:54PM +0530, Vaibhav Gupta wrote: >> Linux Kernel Mentee: Remove Legacy Power Management. >> >> The original goal of the patch series is to upgrade the power management >> framework of radeonfb fbdev driver. This has been done by upgrading .suspend() >> and .resume() callbacks. >> >> The upgrade makes sure that the involvement of PCI Core does not change the >> order of operations executed in a driver. Thus, does not change its behavior. >> >> During this process, it was found that "#if defined(CONFIG_PM)" at line 1434 is >> redundant. This was introduced in the commit >> 42ddb453a0cd ("radeon: Conditionally compile PM code"). > > I do wonder whether it wouldn't be better to just outright delete these, > we have the drm radeon driver for pretty much all the same hardware ...
In contrast to radeonfb, the radeon driver doesn't support suspend-to-RAM on Apple PowerPC notebooks.
-- Earthling Michel Dänzer | https://redhat.com Libre software enthusiast | Mesa and X developer
| |