Messages in this thread | | | Subject | Re: [PATCH 1/1] watchdog: remove unneeded inclusion of <uapi/linux/sched/types.h> | From | "Leizhen (ThunderTown)" <> | Date | Tue, 8 Sep 2020 11:34:47 +0800 |
| |
On 2020/9/8 10:40, Guenter Roeck wrote: > On 9/7/20 12:50 AM, Leizhen (ThunderTown) wrote: >> Hi, Wim Van Sebroeck, Guenter Roeck: >> What's your opinion? Guenter Roeck given "Reviewed-by" two weeks ago. >> > > The patch is in my watchdog-next branch, and Wim usually picks it up > from there.
Oh, thanks.
> > Guenter > >> >> On 2020/8/27 21:40, Guenter Roeck wrote: >>> On 8/26/20 11:21 PM, Zhen Lei wrote: >>>> There has been no reference to "struct sched_param" since >>>> commit 94beddacb53c ("sched,watchdog: Convert to sched_set_fifo()"), so >>>> there's no need to include <uapi/linux/sched/types.h> any more, delete >>>> it. >>>> >>>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> >>> >>> Reviewed-by: Guenter Roeck <linux@roeck-us.net> >>> >>>> --- >>>> drivers/watchdog/watchdog_dev.c | 2 -- >>>> 1 file changed, 2 deletions(-) >>>> >>>> diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c >>>> index 6798addabd5a067..0f18fa2433310b0 100644 >>>> --- a/drivers/watchdog/watchdog_dev.c >>>> +++ b/drivers/watchdog/watchdog_dev.c >>>> @@ -43,8 +43,6 @@ >>>> #include <linux/watchdog.h> /* For watchdog specific items */ >>>> #include <linux/uaccess.h> /* For copy_to_user/put_user/... */ >>>> >>>> -#include <uapi/linux/sched/types.h> /* For struct sched_param */ >>>> - >>>> #include "watchdog_core.h" >>>> #include "watchdog_pretimeout.h" >>>> >>>> >>> >>> >>> >> > > >
| |