Messages in this thread | | | From | Miquel Raynal <> | Subject | Re: [PATCH v2 3/3] mtd: lpddr: Move function print_drs_error to lpddr_cmds.c | Date | Mon, 7 Sep 2020 09:34:34 +0200 |
| |
On Mon, 2020-04-27 at 19:56:08 UTC, "Gustavo A. R. Silva" wrote: > Function print_drs_error is only used in drivers/mtd/lpddr/lpddr_cmds.c > so, better to move it there. > > Also, notice that there's no need for inline as the function is used > once. Lastly, fix the following checkpatch warning: > > WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > +static void print_drs_error(unsigned dsr) > > Suggested-by: Joe Perches <joe@perches.com> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
| |