Messages in this thread | | | Subject | Re: [PATCH] fs: align IOCB_* flags with RWF_* flags | From | Jens Axboe <> | Date | Mon, 7 Sep 2020 13:43:19 -0600 |
| |
On 8/31/20 12:08 PM, Jens Axboe wrote: > We have a set of flags that are shared between the two and inherired > in kiocb_set_rw_flags(), but we check and set these individually. > Reorder the IOCB flags so that the bottom part of the space is synced > with the RWF flag space, and then we can do them all in one mask and > set operation. > > The only exception is RWF_SYNC, which needs to mark IOCB_SYNC and > IOCB_DSYNC. Do that one separately. > > This shaves 15 bytes of text from kiocb_set_rw_flags() for me.
Al, are you OK with me queueing this one up? I'm fine either way, obviously no dependencies for this one, just want to ensure it isn't dropped.
-- Jens Axboe
| |