Messages in this thread | | | Date | Sun, 6 Sep 2020 09:24:19 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v7 0/5] Warn on orphan section placement |
| |
* Kees Cook <keescook@chromium.org> wrote:
> On Fri, Sep 04, 2020 at 07:58:25AM +0200, Ingo Molnar wrote: > > > > * Nick Desaulniers <ndesaulniers@google.com> wrote: > > > > > On Tue, Sep 1, 2020 at 7:53 PM Kees Cook <keescook@chromium.org> wrote: > > > > > > > > Hi Ingo, > > > > > > > > The ever-shortening series. ;) Here is "v7", which is just the remaining > > > > Makefile changes to enable orphan section warnings, now updated to > > > > include ld-option calls. > > > > > > > > Thanks for getting this all into -tip! > > > > > > For the series, > > > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > > > > > > As the recent ppc vdso boogaloo exposed, what about the vdsos? > > > * arch/x86/entry/vdso/Makefile > > > * arch/arm/vdso/Makefile > > > * arch/arm64/kernel/vdso/Makefile > > > * arch/arm64/kernel/vdso32/Makefile > > > > Kees, will these patches DTRT for the vDSO builds? I will be unable to test > > these patches on that old system until tomorrow the earliest. > > I would like to see VDSO done next, but it's entirely separate from > this series. This series only touches the core kernel build (i.e. via the > interactions with scripts/link-vmlinux.sh) or the boot stubs. So there > is no impact on VDSO linking.
Great!
I also double checked that things still build fine with ancient LD.
> > I'm keeping these latest changes in WIP.core/build for now. > > They should be safe to land in -next, which is important so we can shake > out any other sneaky sections that all our existing testing hasn't > found. :)
OK, cool - I've graduated them over into tip:core/build. :-)
Thanks,
Ingo
| |