Messages in this thread | | | Date | Sat, 5 Sep 2020 17:21:22 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH 7/7] arm64: dts: marvell: Add a device tree for the iEi Puzzle-M801 board |
| |
On Sat, Sep 05, 2020 at 03:03:36PM +0200, Luka Kovacic wrote:
> +&cp0_mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + status = "okay"; > + > + ge_phy2: ethernet-phy@2 { > + reg = <0>;
Hi Luka
The value after the @ should be the same as the reg value. So this should be ge_phy2: ethernet-phy@0
> + }; > + > + ge_phy3: ethernet-phy@3 { > + reg = <1>;
And this is:
ge_phy2: ethernet-phy@1
This is a general DT rule, so please check the whole file.
> +&cp0_eth0 { > + status = "okay"; > + phy-mode = "10gbase-r"; > + phys = <&cp0_comphy4 0>; > + local-mac-address = [00 50 43 de ff 00];
Does the bootloader overwrite these with per device MAC addresses?
Looking up this OUI i find:
00:50:43 Marvell Semiconductor, Inc.
I'm not sure you should be using that!
Andrew
| |