lkml.org 
[lkml]   [2020]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] iommu: qcom: Drop of_match_ptr to fix -Wunused-const-variable
On Tue 28 Jul 12:08 CDT 2020, Krzysztof Kozlowski wrote:

> The of_device_id is included unconditionally by of.h header and used
> in the driver as well. Remove of_match_ptr to fix W=1 compile test
> warning with !CONFIG_OF:
>
> drivers/iommu/qcom_iommu.c:910:34: warning: 'qcom_iommu_of_match' defined but not used [-Wunused-const-variable=]
> 910 | static const struct of_device_id qcom_iommu_of_match[] = {
>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/iommu/qcom_iommu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c
> index af6bec3ace00..9535a6af7553 100644
> --- a/drivers/iommu/qcom_iommu.c
> +++ b/drivers/iommu/qcom_iommu.c
> @@ -752,7 +752,7 @@ static const struct of_device_id ctx_of_match[] = {
> static struct platform_driver qcom_iommu_ctx_driver = {
> .driver = {
> .name = "qcom-iommu-ctx",
> - .of_match_table = of_match_ptr(ctx_of_match),
> + .of_match_table = ctx_of_match,
> },
> .probe = qcom_iommu_ctx_probe,
> .remove = qcom_iommu_ctx_remove,
> @@ -915,7 +915,7 @@ static const struct of_device_id qcom_iommu_of_match[] = {
> static struct platform_driver qcom_iommu_driver = {
> .driver = {
> .name = "qcom-iommu",
> - .of_match_table = of_match_ptr(qcom_iommu_of_match),
> + .of_match_table = qcom_iommu_of_match,
> .pm = &qcom_iommu_pm_ops,
> },
> .probe = qcom_iommu_device_probe,
> --
> 2.17.1
>

\
 
 \ /
  Last update: 2020-09-04 16:57    [W:0.202 / U:0.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site