Messages in this thread | | | Date | Fri, 4 Sep 2020 09:35:07 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v2] staging: media: atomisp: Fix error path in lm3554_probe() |
| |
On Thu, Sep 03, 2020 at 07:24:51PM +0100, Alex Dewar wrote: > + > + ret = atomisp_register_i2c_module(&flash->sd, NULL, LED_FLASH); > + if (!ret) > + return 0;
Ugh!!! This is a a special case of the "success handling instead of failure handling" anti-pattern where the last condition in the function is different. I just fixed a bug caused by this on Wed.
https://www.spinics.net/lists/netdev/msg680226.html
But it doesn't cause any problems here so whatever...
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards, dan carpenter
| |