Messages in this thread | | | Date | Fri, 4 Sep 2020 17:09:57 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next 8/9] net: ethernet: ti: ale: switch to use tables for vlan entry description |
| |
On Sat, 5 Sep 2020 02:09:23 +0300 Grygorii Strashko wrote: > The ALE VLAN entries are too much differ between different TI CPSW ALE > versions. So, handling them using flags, defines and get/set functions > became over-complicated. > > This patch introduces tables to describe the ALE VLAN entries fields, which > are different between TI CPSW ALE versions, and new get/set access > functions. It also allows to detect incorrect access to not available ALL > entry fields.
When building with W=1 C=1:
drivers/net/ethernet/ti/cpsw_ale.c:179:28: warning: symbol 'vlan_entry_cpsw' was not declared. Should it be static? drivers/net/ethernet/ti/cpsw_ale.c:187:28: warning: symbol 'vlan_entry_nu' was not declared. Should it be static? drivers/net/ethernet/ti/cpsw_ale.c:63: warning: Function parameter or member 'num_bits' not described in 'ale_entry_fld'
| |